]> git.ipfire.org Git - thirdparty/suricata.git/commitdiff
stream: fix --disable-detection reassembly issue 1463/head
authorVictor Julien <victor@inliniac.net>
Wed, 6 May 2015 11:08:32 +0000 (13:08 +0200)
committerVictor Julien <victor@inliniac.net>
Wed, 6 May 2015 11:08:32 +0000 (13:08 +0200)
Due to an error at initialization, the stream engine would not disable
'raw' reassembly automatically when --disable-detection was used.

This lead to segments not getting cleared from the segment lists.

src/suricata.c

index 9ad4b8be9d825eaa3f9f7cf77e85d9d9915a7af5..778ecebdfec69a4390b9321c66525682d4fc4f26 100644 (file)
@@ -2201,6 +2201,11 @@ int main(int argc, char **argv)
     NSS_NoDB_Init(NULL);
 #endif
 
+    if (suri.disabled_detect) {
+        /* disable raw reassembly */
+        (void)ConfSetFinal("stream.reassembly.raw", "false");
+    }
+
     PacketPoolInit(max_pending_packets);
     HostInitConfig(HOST_VERBOSE);
     if (suri.run_mode != RUNMODE_UNIX_SOCKET) {
@@ -2228,9 +2233,6 @@ int main(int argc, char **argv)
             exit(EXIT_FAILURE);
         }
     } else {
-        /* disable raw reassembly */
-        (void)ConfSetFinal("stream.reassembly.raw", "false");
-
         /* tell the app layer to consider only the log id */
         RegisterAppLayerGetActiveTxIdFunc(AppLayerTransactionGetActiveLogOnly);
     }