dnsdist: Fix a few warnings from Coverity

diff --git a/pdns/dnsdistdist/bpf-filter.cc b/pdns/dnsdistdist/bpf-filter.cc
index db8c358b1c922e29ef263d8b6d0fd2372892db91..700f32467dfbf82dd6ad8a8a5afeae01db6f4097 100644 (file)
--- a/pdns/dnsdistdist/bpf-filter.cc
+++ b/pdns/dnsdistdist/bpf-filter.cc
@@ -392,7 +392,7 @@ BPFFilter::BPFFilter(std::unordered_map<std::string, MapConfiguration>& configs,
     BPFFilter::MapConfiguration filters;
     filters.d_maxItems = 1;
     filters.d_type = BPFFilter::MapType::Filters;
-    maps->d_filters = BPFFilter::Map(filters, d_mapFormat);
+    maps->d_filters = BPFFilter::Map(std::move(filters), d_mapFormat);
 
     const struct bpf_insn main_filter[] = {
 #include "bpf-filter.main.ebpf"

diff --git a/pdns/dnsdistdist/dnsdist-web.cc b/pdns/dnsdistdist/dnsdist-web.cc
index 526b0bc8535876863b4c0311c27bebcabd1aa688..5cdfead09cd0629898ac6f2818deac53b4996dd3 100644 (file)
--- a/pdns/dnsdistdist/dnsdist-web.cc
+++ b/pdns/dnsdistdist/dnsdist-web.cc
@@ -1908,6 +1908,7 @@ void setMaxConcurrentConnections(size_t max)
 void WebserverThread(Socket sock)
 {
   setThreadName("dnsdist/webserv");
+  //coverity[auto_causes_copy]
   const auto local = *dnsdist::configuration::getCurrentRuntimeConfiguration().d_webServerAddress;
   infolog("Webserver launched on %s", local.toStringWithPort());
 

diff --git a/pdns/dnsdistdist/dnsdist.cc b/pdns/dnsdistdist/dnsdist.cc
index 8f196475f577062dcef1a2ffb42eb3876edfae39..0efef3add929eac901134e9e9eaa7ab6d9d670b3 100644 (file)
--- a/pdns/dnsdistdist/dnsdist.cc
+++ b/pdns/dnsdistdist/dnsdist.cc
@@ -2340,6 +2340,7 @@ static void healthChecksThread()
 
     std::unique_ptr<FDMultiplexer> mplexer{nullptr};
     // this points to the actual shared_ptrs!
+    //coverity[auto_causes_copy]
     const auto servers = dnsdist::configuration::getCurrentRuntimeConfiguration().d_backends;
     for (const auto& dss : servers) {
       dss->updateStatisticsInfo();