dnsdist: Add more context to the new build settings

So we can actually check later if they are still needed.

diff --git a/builder-support/debian/dnsdist/debian-bookworm/rules b/builder-support/debian/dnsdist/debian-bookworm/rules
index 4fcc760301e33c06ba1cd01f743d2a1b48a62115..c02ed55e8004e10524eed0b6d66c05d26e0924a7 100755 (executable)
--- a/builder-support/debian/dnsdist/debian-bookworm/rules
+++ b/builder-support/debian/dnsdist/debian-bookworm/rules
@@ -11,8 +11,8 @@ include /usr/share/dpkg/default.mk
 # for atomic support on powerpc (automatic on mipsel)
 LDFLAGS += -latomic
 # We need clang (LLVM) to link the Rust static library and the C++ code with LTO enabled
-# build-id SHA1 prevents an issue with the debug symbols
-# and the --no-as-needed -ldl an issue with the dlsym not being found
+# build-id SHA1 prevents an issue with the debug symbols ("export: `-Wl,--build-id=sha1': not a valid identifier")
+# and the --no-as-needed -ldl an issue with the dlsym not being found ("ld.lld: error: undefined symbol: dlsym eferenced by weak.rs:142 (library/std/src/sys/pal/unix/weak.rs:142) [...] in archive ./dnsdist-rust-lib/rust/libdnsdist_rust.a)
 LDFLAGS += -fuse-ld=lld -Wl,--build-id=sha1 -Wl,--no-as-needed -ldl
 CC=clang
 CXX=clang++

diff --git a/builder-support/debian/dnsdist/debian-buster/rules b/builder-support/debian/dnsdist/debian-buster/rules
index ce9621d127fcdd55e42b3acdcd8529d0b5ccc0d8..a19db4f1b9391b92db3c3442c5b3130c4e91f2d1 100755 (executable)
--- a/builder-support/debian/dnsdist/debian-buster/rules
+++ b/builder-support/debian/dnsdist/debian-buster/rules
@@ -11,8 +11,8 @@ include /usr/share/dpkg/default.mk
 # for atomic support on powerpc (automatic on mipsel)
 LDFLAGS += -latomic
 # We need clang (LLVM) to link the Rust static library and the C++ code with LTO enabled
-# build-id SHA1 prevents an issue with the debug symbols
-# and the --no-as-needed -ldl an issue with the dlsym not being found
+# build-id SHA1 prevents an issue with the debug symbols ("export: `-Wl,--build-id=sha1': not a valid identifier")
+# and the --no-as-needed -ldl an issue with the dlsym not being found ("ld.lld: error: undefined symbol: dlsym eferenced by weak.rs:142 (library/std/src/sys/pal/unix/weak.rs:142) [...] in archive ./dnsdist-rust-lib/rust/libdnsdist_rust.a)
 LDFLAGS += -fuse-ld=lld -Wl,--build-id=sha1 -Wl,--no-as-needed -ldl
 CC=clang
 CXX=clang++

diff --git a/builder-support/specs/dnsdist.spec b/builder-support/specs/dnsdist.spec
index 476b279c8859039734bbdff2c817e3e14e6caf42..42e156fdb34113442b1feb2e01b19a820acc8311 100644 (file)
--- a/builder-support/specs/dnsdist.spec
+++ b/builder-support/specs/dnsdist.spec
@@ -81,8 +81,8 @@ export LDFLAGS=-L/usr/lib64/boost169
 # We need to build with LLVM/clang to be able to use LTO, since we are linking against a static Rust library built with LLVM
 export CC=clang
 export CXX=clang++
-# build-id SHA1 prevents an issue with the debug symbols
-# and the --no-as-needed -ldl an issue with the dlsym not being found
+# build-id SHA1 prevents an issue with the debug symbols ("export: `-Wl,--build-id=sha1': not a valid identifier")
+# and the --no-as-needed -ldl an issue with the dlsym not being found ("ld.lld: error: undefined symbol: dlsym eferenced by weak.rs:142 (library/std/src/sys/pal/unix/weak.rs:142) [...] in archive ./dnsdist-rust-lib/rust/libdnsdist_rust.a)
 export LDFLAGS="-fuse-ld=lld -Wl,--build-id=sha1 -Wl,--no-as-needed -ldl"
 %endif