Tidy annotations

diff --git a/pdns/recursordist/syncres.cc b/pdns/recursordist/syncres.cc
index a384f5966f868608baeae7d53c250a998dd652ee..140ef7a45ac9e9e8d4bb0a5dacc4c42ab3cfee0a 100644 (file)
--- a/pdns/recursordist/syncres.cc
+++ b/pdns/recursordist/syncres.cc
@@ -4183,6 +4183,7 @@ static void allowAdditionalEntry(std::unordered_set<DNSName>& allowedAdditionals
   }
 }
 
+// NOLINTNEXTLINE(readability-function-cognitive-complexity)
 void SyncRes::sanitizeRecords(const std::string& prefix, LWResult& lwr, const DNSName& qname, const QType qtype, const DNSName& auth, bool wasForwarded, bool rdQuery)
 {
   const bool wasForwardRecurse = wasForwarded && rdQuery;

diff --git a/pdns/recursordist/test-syncres_cc1.cc b/pdns/recursordist/test-syncres_cc1.cc
index d9415479d2bd0f21dd307fc09f08260ede8f0c09..713405e8de43a446bed5e0ddba44eb19caf53932 100644 (file)
--- a/pdns/recursordist/test-syncres_cc1.cc
+++ b/pdns/recursordist/test-syncres_cc1.cc
@@ -1483,6 +1483,7 @@ BOOST_AUTO_TEST_CASE(test_following_cname_with_a)
   const DNSName target("cname.powerdns.com.");
   const DNSName cnameTarget("cname-target.powerdns.com");
 
+  // NOLINTNEXTLINE(performance-unnecessary-value-param)
   resolver->setAsyncCallback([&](const ComboAddress& address, const DNSName& domain, int /* type */, bool /* doTCP */, bool /* sendRDQuery */, int /* EDNS0Level */, struct timeval* /* now */, boost::optional<Netmask>& /* srcmask */, boost::optional<const ResolveContext&> /* context */, LWResult* res, bool* /* chained */) {
     if (isRootServer(address)) {
       setLWResult(res, 0, false, false, true);
@@ -1531,6 +1532,7 @@ BOOST_AUTO_TEST_CASE(test_following_cname_chain_with_a)
   const DNSName cnameTarget1("cname-target1.powerdns.com");
   const DNSName cnameTarget("cname-target.powerdns.com");
 
+  // NOLINTNEXTLINE(performance-unnecessary-value-param)
   resolver->setAsyncCallback([&](const ComboAddress& address, const DNSName& domain, int /* type */, bool /* doTCP */, bool /* sendRDQuery */, int /* EDNS0Level */, struct timeval* /* now */, boost::optional<Netmask>& /* srcmask */, boost::optional<const ResolveContext&> /* context */, LWResult* res, bool* /* chained */) {
     if (isRootServer(address)) {
       setLWResult(res, 0, false, false, true);