dnsdist: Fix a performance inefficiency reported by Coverity

As CID 490492 (`AUTO_CAUSES_COPY`).

Signed-off-by: Remi Gacogne <remi.gacogne@powerdns.com>

diff --git a/pdns/dnsdistdist/dnsdist-lua.cc b/pdns/dnsdistdist/dnsdist-lua.cc
index 24af5ce78ba359c1e9870824cf4c352fc20c65ad..1099ac3f16018ba55542625c86f35f2ff0926fa7 100644 (file)
--- a/pdns/dnsdistdist/dnsdist-lua.cc
+++ b/pdns/dnsdistdist/dnsdist-lua.cc
@@ -2074,7 +2074,7 @@ static void setupLuaConfig(LuaContext& luaCtx, bool client, bool configCheck)
 
   luaCtx.writeFunction("showPoolServerPolicy", [](const std::string& pool) {
     setLuaSideEffect();
-    auto poolObj = getPool(pool);
+    const auto& poolObj = getPool(pool);
     if (poolObj.policy == nullptr) {
       g_outputBuffer = dnsdist::configuration::getCurrentRuntimeConfiguration().d_lbPolicy->getName() + "\n";
     }