rec: Fix a few Coverity found issues, all low severity move optimizations

Signed-off-by: Otto Moerbeek <otto.moerbeek@open-xchange.com>

diff --git a/pdns/protozero-trace.hh b/pdns/protozero-trace.hh
index 9dfed07861c7325dc0f3821d7ada5ce3aa1c174c..d739c26a82c5d3385925d4996fade2bd872dc6f4 100644 (file)
--- a/pdns/protozero-trace.hh
+++ b/pdns/protozero-trace.hh
@@ -740,7 +740,7 @@ struct TracesData
     InstrumentationScope scope{
       .name = "rec", .version = VERSION, .attributes = {{"hostname", {hostname}}, {"server.id", {serverID}}}};
     return TracesData{
-      .resource_spans = {pdns::trace::ResourceSpans{.resource = {.attributes = {{"service.name", {{std::move(service)}}}}}, .scope_spans = {{.scope = scope, .spans = std::move(spans)}}}}};
+      .resource_spans = {pdns::trace::ResourceSpans{.resource = {.attributes = {{"service.name", {{std::move(service)}}}}}, .scope_spans = {{.scope = std::move(scope), .spans = std::move(spans)}}}}};
   }
 };
 

diff --git a/pdns/rcpgenerator.cc b/pdns/rcpgenerator.cc
index 7bbbd62e232178655f9b3c3e3fa79da980d00cf4..f3e930b8cdfe46b427e398edb02f3b0fa60ea5b2 100644 (file)
--- a/pdns/rcpgenerator.cc
+++ b/pdns/rcpgenerator.cc
@@ -1044,7 +1044,7 @@ void RecordTextWriter::xfrSvcParamKeyVals(const set<SvcParam>& val) {
         str += std::to_string(group);
         first = false;
       }
-      d_string = str;
+      d_string = std::move(str);
       break;
     }
     case SvcParam::dohpath:

diff --git a/pdns/recursordist/lwres.cc b/pdns/recursordist/lwres.cc
index 82ed0d12e961e82167fca23474e174161033da5c..6171aca9ab901e36c519ca6ebe8748f9c0d78d7e 100644 (file)
--- a/pdns/recursordist/lwres.cc
+++ b/pdns/recursordist/lwres.cc
@@ -424,7 +424,7 @@ static bool tcpconnect(const OptLog& log, const ComboAddress& remote, const std:
     }
     else {
       if (subjectName.empty() && !subjectAddress.empty()) {
-        subjectName = subjectAddress;
+        subjectName = std::move(subjectAddress);
         subjectIsAddress = true;
       }
       if (subjectName.empty()) {

diff --git a/pdns/recursordist/rec_channel_rec.cc b/pdns/recursordist/rec_channel_rec.cc
index d87f0ba327955fb3ee9caeb3026e5c9f56fff0de..c9dcc86836af1cf551f79b6e5253798a19385e25 100644 (file)
--- a/pdns/recursordist/rec_channel_rec.cc
+++ b/pdns/recursordist/rec_channel_rec.cc
@@ -616,7 +616,7 @@ static Answer doSetCarbonServer(ArgIterator begin, ArgIterator end)
   }
 
   g_carbonConfig.setState(std::move(config));
-  return {0, ret};
+  return {0, std::move(ret)};
 }
 
 static Answer doSetDnssecLogBogus(ArgIterator begin, ArgIterator end)