]> git.ipfire.org Git - thirdparty/systemd.git/commitdiff
tests: log_tests_skipped() already appends ", skipping tests" 22014/head
authorZbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
Tue, 4 Jan 2022 11:02:11 +0000 (12:02 +0100)
committerZbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
Wed, 5 Jan 2022 10:59:22 +0000 (11:59 +0100)
We would say:
test-bpf-lsm: Can't use mlock(), skipping., skipping tests.

src/libsystemd/sd-device/test-sd-device-monitor.c
src/test/test-bpf-foreign-programs.c
src/test/test-bpf-lsm.c
src/test/test-socket-bind.c

index ae973cdba395aa03e91caac9688868c64d628ad6..e6b289e6e4347fb222bbaa46bc2fee34b90188bf 100644 (file)
@@ -302,7 +302,7 @@ int main(int argc, char *argv[]) {
         r = test_receive_device_fail();
         if (r < 0) {
                 assert_se(r == -EPERM && detect_container() > 0);
-                return log_tests_skipped("Running in container? Skipping remaining tests");
+                return log_tests_skipped("Running in container");
         }
 
         assert_se(sd_device_new_from_syspath(&loopback, "/sys/class/net/lo") >= 0);
index 1765dc7a9be407fbc539e0cc5578c24244d7f861..8c3f76e9ec8bfa31e4fae8bc6746ecbdb8bda760 100644 (file)
@@ -289,11 +289,11 @@ int main(int argc, char *argv[]) {
         (void) setrlimit_closest(RLIMIT_MEMLOCK, &rl);
 
         if (!can_memlock())
-                return log_tests_skipped("Can't use mlock(), skipping.");
+                return log_tests_skipped("Can't use mlock()");
 
         r = cg_all_unified();
         if (r <= 0)
-                return log_tests_skipped("Unified hierarchy is required, skipping.");
+                return log_tests_skipped("Unified hierarchy is required");
 
         r = enter_cgroup_subroot(NULL);
         if (r == -ENOMEDIUM)
index 302276729533f7f079b4607878eda016714eac54..60d1789a0a2d3987a6873dc006fcc2cb5eba98a4 100644 (file)
@@ -77,7 +77,7 @@ int main(int argc, char *argv[]) {
         (void) setrlimit_closest(RLIMIT_MEMLOCK, &rl);
 
         if (!can_memlock())
-                return log_tests_skipped("Can't use mlock(), skipping.");
+                return log_tests_skipped("Can't use mlock()");
 
         r = lsm_bpf_supported();
         if (r <= 0)
index ecad86baebff0738463de64e45b7c6af69251b1b..f4197aaf3c02469696165c94e7931853ff1b0d87 100644 (file)
@@ -120,14 +120,14 @@ int main(int argc, char *argv[]) {
         (void) setrlimit_closest(RLIMIT_MEMLOCK, &rl);
 
         if (!can_memlock())
-                return log_tests_skipped("Can't use mlock(), skipping.");
+                return log_tests_skipped("Can't use mlock()");
 
         r = bpf_socket_bind_supported();
         if (r <= 0)
-                return log_tests_skipped("socket-bind is not supported, skipping.");
+                return log_tests_skipped("socket-bind is not supported");
 
         if (find_netcat_executable(&netcat_path) != 0)
-                return log_tests_skipped("Can not find netcat executable, skipping.");
+                return log_tests_skipped("Can not find netcat executable");
 
         r = enter_cgroup_subroot(NULL);
         if (r == -ENOMEDIUM)