]> git.ipfire.org Git - thirdparty/systemd.git/commitdiff
bpf: fix bpf_can_link_lsm_program condition 22050/head
authorJulia Kartseva <hex@fb.com>
Mon, 10 Jan 2022 05:35:35 +0000 (21:35 -0800)
committerJulia Kartseva <hex@fb.com>
Mon, 10 Jan 2022 05:45:50 +0000 (21:45 -0800)
Since bpf_can_link_lsm_program return value is boolean, the expression
`r < 0` is always false.

src/core/bpf-lsm.c

index 4ca082a0050bb62518bf50ec53a57c3f4d77b367..83f3199349ce2a78b8f8a8de45887242d6bcfb12 100644 (file)
@@ -167,9 +167,9 @@ int lsm_bpf_supported(void) {
         if (r < 0)
                 return supported = 0;
 
-        r = bpf_can_link_lsm_program(obj->progs.restrict_filesystems);
-        if (r < 0) {
-                log_warning_errno(r, "Failed to link BPF program. Assuming BPF is not available: %m");
+        if (!bpf_can_link_lsm_program(obj->progs.restrict_filesystems)) {
+                log_warning_errno(SYNTHETIC_ERRNO(EOPNOTSUPP),
+                                  "Failed to link BPF program. Assuming BPF is not available");
                 return supported = 0;
         }