[Minor] Test & fix has_only_html_part regression

diff --git a/src/libmime/mime_expressions.c b/src/libmime/mime_expressions.c
index 88e9e16a1bd54103334d307ed89e0ba0399ae380..60cfe7b02336b048c00812ef7888ff6da11a5b3f 100644 (file)
--- a/src/libmime/mime_expressions.c
+++ b/src/libmime/mime_expressions.c
@@ -1470,8 +1470,6 @@ rspamd_has_only_html_part(struct rspamd_task *task, GArray *args,
 
        PTR_ARRAY_FOREACH(MESSAGE_FIELD(task, text_parts), i, p)
        {
-               p = g_ptr_array_index(MESSAGE_FIELD(task, text_parts), 0);
-
                if (!IS_TEXT_PART_ATTACHMENT(p)) {
                        if (IS_TEXT_PART_HTML(p)) {
                                cnt_html++;

diff --git a/test/functional/cases/001_merged/100_general.robot b/test/functional/cases/001_merged/100_general.robot
index b06dd14927eee308bb1c978ba3836f16bf50c7a8..16b9b5f5aa5538a9c51bc230eaa056d4db656c6f 100644 (file)
--- a/test/functional/cases/001_merged/100_general.robot
+++ b/test/functional/cases/001_merged/100_general.robot
@@ -49,3 +49,13 @@ EMAILS DETECTION ZEROFONT
   ...  Settings={symbols_enabled = [MANY_INVISIBLE_PARTS, ZERO_FONT]}
   Expect Symbol  MANY_INVISIBLE_PARTS
   Expect Symbol  ZERO_FONT
+
+HTML ONLY - TRUE POSITIVE
+  Scan File  ${RSPAMD_TESTDIR}/messages/zerofont.eml
+  ...  Settings={symbols_enabled = [MIME_HTML_ONLY]}
+  Expect Symbol  MIME_HTML_ONLY
+
+HTML ONLY - TRUE NEGATIVE
+  Scan File  ${RSPAMD_TESTDIR}/messages/btc.eml
+  ...  Settings={symbols_enabled = [MIME_HTML_ONLY]}
+  Do Not Expect Symbol  MIME_HTML_ONLY