]> git.ipfire.org Git - thirdparty/pdns.git/commitdiff
geoipbackend: Allow empty content for ENT record 7196/head
authorAki Tuomi <cmouse@cmouse.fi>
Wed, 14 Nov 2018 11:19:39 +0000 (13:19 +0200)
committerAki Tuomi <cmouse@cmouse.fi>
Wed, 14 Nov 2018 11:28:51 +0000 (13:28 +0200)
Fixes #7195

modules/geoipbackend/geoipbackend.cc
modules/geoipbackend/regression-tests/ent-resolution/command [new file with mode: 0755]
modules/geoipbackend/regression-tests/ent-resolution/description [new file with mode: 0644]
modules/geoipbackend/regression-tests/ent-resolution/expected_result [new file with mode: 0644]

index de1d2ffa6076cb0c897b597245e629564ed779ab..5ed467b6dd6228c5d93e73c4c14600cb21157ff7 100644 (file)
@@ -321,7 +321,7 @@ bool GeoIPBackend::lookup_static(const GeoIPDomain &dom, const DNSName &search,
       }
       if (qtype == QType::ANY || rr.qtype == qtype) {
         const string& content = format2str(rr.content, ip, v6, gl);
-        if (rr.qtype != QType::TXT && content.empty()) continue;
+        if (rr.qtype != QType::ENT && rr.qtype != QType::TXT && content.empty()) continue;
         d_result.push_back(rr);
         d_result.back().content = content;
         d_result.back().qname = qdomain;
diff --git a/modules/geoipbackend/regression-tests/ent-resolution/command b/modules/geoipbackend/regression-tests/ent-resolution/command
new file mode 100755 (executable)
index 0000000..6f14024
--- /dev/null
@@ -0,0 +1,3 @@
+#!/bin/sh
+
+cleandig o1.city.geo.example.com A
diff --git a/modules/geoipbackend/regression-tests/ent-resolution/description b/modules/geoipbackend/regression-tests/ent-resolution/description
new file mode 100644 (file)
index 0000000..781bb70
--- /dev/null
@@ -0,0 +1 @@
+This test ensures that non-empty terminals are processed correctly.
diff --git a/modules/geoipbackend/regression-tests/ent-resolution/expected_result b/modules/geoipbackend/regression-tests/ent-resolution/expected_result
new file mode 100644 (file)
index 0000000..1c333a8
--- /dev/null
@@ -0,0 +1,3 @@
+1      geo.example.com.        IN      SOA     30      ns1.example.com. hostmaster.example.com. 2014090125 7200 3600 1209600 3600
+Rcode: 0 (No Error), RD: 0, QR: 1, TC: 0, AA: 1, opcode: 0
+Reply to question for qname='o1.city.geo.example.com.', qtype=A