]> git.ipfire.org Git - thirdparty/pdns.git/commitdiff
fix off-by-one in mvRule counting 7426/head
authorPeter van Dijk <peter.van.dijk@powerdns.com>
Sun, 27 Jan 2019 18:16:12 +0000 (19:16 +0100)
committerPeter van Dijk <peter.van.dijk@powerdns.com>
Sun, 27 Jan 2019 18:16:16 +0000 (19:16 +0100)
this makes mvRule(0,x) work where x is the highest rule number

pdns/dnsdist-lua-rules.cc

index 9d83032bf95a95ee5dbca728de4bcfd3f6ba6dd9..ef02dcffcc3efebab4424e31b0da40618c6b8931 100644 (file)
@@ -168,7 +168,7 @@ static void mvRule(GlobalStateHolder<vector<T> > *someRespRulActions, unsigned i
   }
   auto subject = rules[from];
   rules.erase(rules.begin()+from);
-  if(to == rules.size())
+  if(to > rules.size())
     rules.push_back(subject);
   else {
     if(from < to)