rec: Don't copy the records when scanning for CNAME loops

diff --git a/pdns/syncres.cc b/pdns/syncres.cc
index 27b78cd2883d03a06bd24770320307a1e2291f12..25851874270a0b331a03b2323ae833c257438b56 100644 (file)
--- a/pdns/syncres.cc
+++ b/pdns/syncres.cc
@@ -1174,7 +1174,7 @@ void SyncRes::updateValidationStatusInCache(const DNSName &qname, const QType& q
 
 static bool scanForCNAMELoop(const DNSName& name, const vector<DNSRecord>& records)
 {
-  for (const auto record: records) {
+  for (const auto& record: records) {
     if (record.d_type == QType::CNAME && record.d_place == DNSResourceRecord::ANSWER) {
       if (name == record.d_name) {
         return true;