From: Lennart Poettering <lennart@poettering.net>
Date: Thu, 28 Mar 2019 08:26:50 +0000 (+0100)
Subject: sd-bus: change "int" → "signed int" on bitfield
X-Git-Tag: v242-rc1~49
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;ds=sidebyside;h=b8a736d7a0e8ee00bdd026bb4c68c50bbe49d2ef;p=thirdparty%2Fsystemd.git

sd-bus: change "int" → "signed int" on bitfield

Apparently by the C standard "int" bitfields can have any signedness
(unlike non-bitfield declarations which are "signed" if the signedness
is not specified).

Let's fix the LGTM warning about this hence and be explicit that we mean
"signed" here.
---

diff --git a/src/libsystemd/sd-bus/bus-internal.h b/src/libsystemd/sd-bus/bus-internal.h
index 5d6cce01685..d7fcb9329b9 100644
--- a/src/libsystemd/sd-bus/bus-internal.h
+++ b/src/libsystemd/sd-bus/bus-internal.h
@@ -211,7 +211,7 @@ struct sd_bus {
         bool connected_signal:1;
         bool close_on_exit:1;
 
-        int use_memfd:2;
+        signed int use_memfd:2;
 
         void *rbuffer;
         size_t rbuffer_size;