From: Alexander Marx <amarx@ipfire.org>
Date: Mon, 4 Nov 2013 07:04:44 +0000 (+0100)
Subject: Firewall: Bugfix: When creating a servcie in firewall-groups and selecting a protocol... 
X-Git-Tag: v2.15-beta1~162
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;ds=sidebyside;h=f8cbcb7c8ac944c54c57023fe7951ac1770941c2;p=ipfire-2.x.git

Firewall: Bugfix: When creating a servcie in firewall-groups and selecting a protocol other than icmp, the enty in the ruletable shows correct values PLUS the "all icmp-types" under ICMP.
Now the ICMP FIeld is emtpy when selecting another protocol than icmp
---

diff --git a/html/cgi-bin/fwhosts.cgi b/html/cgi-bin/fwhosts.cgi
index fd66a49414..91de897ec9 100755
--- a/html/cgi-bin/fwhosts.cgi
+++ b/html/cgi-bin/fwhosts.cgi
@@ -741,6 +741,7 @@ if ($fwhostsettings{'ACTION'} eq 'saveservice')
 		}
 	}
 	if($ICMP eq ''){$ICMP=$fwhostsettings{'ICMP_TYPES'};}
+	if ($fwhostsettings{'PROT'} ne 'ICMP'){$ICMP='';}
 	if (!$errormessage){
 		my $key = &General::findhasharraykey (\%customservice);
 		foreach my $i (0 .. 4) { $customservice{$key}[$i] = "";}