From: Martin Kaiser Date: Tue, 6 Apr 2021 20:48:24 +0000 (+0200) Subject: staging: rtl8188eu: clean up usb_read16 X-Git-Tag: v5.13-rc1~173^2~179 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=00092615162f8ed8ca33cec36ddbd7804c4acbb5;p=thirdparty%2Fkernel%2Flinux.git staging: rtl8188eu: clean up usb_read16 Remove unnecessary variable, summarize declaration and assignment. Signed-off-by: Martin Kaiser Link: https://lore.kernel.org/r/20210406204829.18130-6-martin@kaiser.cx Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/staging/rtl8188eu/os_dep/usb_ops_linux.c b/drivers/staging/rtl8188eu/os_dep/usb_ops_linux.c index 0172405c815e2..915bf86237b01 100644 --- a/drivers/staging/rtl8188eu/os_dep/usb_ops_linux.c +++ b/drivers/staging/rtl8188eu/os_dep/usb_ops_linux.c @@ -306,13 +306,10 @@ u8 usb_read8(struct adapter *adapter, u32 addr) u16 usb_read16(struct adapter *adapter, u32 addr) { - u16 wvalue; - u16 len; + u16 wvalue = (u16)(addr & 0xffff); __le32 data; - wvalue = (u16)(addr & 0x0000ffff); - len = 2; - usbctrl_vendorreq(adapter, wvalue, &data, len, REALTEK_USB_VENQT_READ); + usbctrl_vendorreq(adapter, wvalue, &data, 2, REALTEK_USB_VENQT_READ); return (u16)(le32_to_cpu(data) & 0xffff); }