From: Stephan Bosch <stephan.bosch@open-xchange.com>
Date: Mon, 8 Nov 2021 22:29:35 +0000 (+0100)
Subject: lib-smtp: smtp-client-transaction - Make smtp_client_transaction_rcpt_fail_reply... 
X-Git-Tag: 2.3.18~121
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=0037fb7bad25db0572e1110ae3648e05fb321ca1;p=thirdparty%2Fdovecot%2Fcore.git

lib-smtp: smtp-client-transaction - Make smtp_client_transaction_rcpt_fail_reply(NULL, reply) a no-op.
---

diff --git a/src/lib-smtp/smtp-client-transaction.c b/src/lib-smtp/smtp-client-transaction.c
index a7f323cd0a..c86e173cb6 100644
--- a/src/lib-smtp/smtp-client-transaction.c
+++ b/src/lib-smtp/smtp-client-transaction.c
@@ -380,6 +380,11 @@ smtp_client_transaction_rcpt_fail_reply(
 	const struct smtp_reply *reply)
 {
 	struct smtp_client_transaction_rcpt *rcpt = *_rcpt;
+
+	if (rcpt == NULL)
+		return;
+	*_rcpt = NULL;
+
 	struct smtp_client_transaction *trans = rcpt->trans;
 	smtp_client_command_callback_t *callback;
 	void *context;
@@ -409,7 +414,7 @@ smtp_client_transaction_rcpt_fail_reply(
 	if (callback != NULL)
 		callback(reply, context);
 
-	smtp_client_transaction_rcpt_free(_rcpt);
+	smtp_client_transaction_rcpt_free(&rcpt);
 }
 
 static void