From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Mon, 15 Mar 2021 09:23:37 +0000 (+0300)
Subject: rtw88: Fix an error code in rtw_debugfs_set_rsvd_page()
X-Git-Tag: v5.10.37~120
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=00792f31a330cb5da7ae35dba6a2e9d8c6211c83;p=thirdparty%2Fkernel%2Fstable.git

rtw88: Fix an error code in rtw_debugfs_set_rsvd_page()

[ Upstream commit c9eaee0c2ec6b1002044fb698cdfb5d9ef4ed28c ]

The sscanf() function returns the number of matches (0 or 1 in this
case).  It doesn't return error codes.  We should return -EINVAL if the
string is invalid

Fixes: c376c1fc87b7 ("rtw88: add h2c command in debugfs")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Link: https://lore.kernel.org/r/YE8nmatMDBDDWkjq@mwanda
Signed-off-by: Sasha Levin <sashal@kernel.org>
---

diff --git a/drivers/net/wireless/realtek/rtw88/debug.c b/drivers/net/wireless/realtek/rtw88/debug.c
index efbba9caef3bf..8bb6cc8ca74e5 100644
--- a/drivers/net/wireless/realtek/rtw88/debug.c
+++ b/drivers/net/wireless/realtek/rtw88/debug.c
@@ -270,7 +270,7 @@ static ssize_t rtw_debugfs_set_rsvd_page(struct file *filp,
 
 	if (num != 2) {
 		rtw_warn(rtwdev, "invalid arguments\n");
-		return num;
+		return -EINVAL;
 	}
 
 	debugfs_priv->rsvd_page.page_offset = offset;