From: Jeff King Date: Tue, 4 Jun 2024 10:13:32 +0000 (-0400) Subject: sparse-checkout: free sparse_filename after use X-Git-Tag: v2.46.0-rc0~62^2~3 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=008f59d2d6b3be1017d8d321985b89d85659df04;p=thirdparty%2Fgit.git sparse-checkout: free sparse_filename after use We allocate a heap buffer via get_sparse_checkout_filename(). Most calls remember to free it, but sparse_checkout_init() forgets to, causing a leak. Ironically, it remembers to do so in the error return paths, but not in the path that makes it all the way to the function end! Fixing this clears up 6 leaks from t1091. Signed-off-by: Jeff King Signed-off-by: Junio C Hamano --- diff --git a/builtin/sparse-checkout.c b/builtin/sparse-checkout.c index b84d2e1c80..79342480eb 100644 --- a/builtin/sparse-checkout.c +++ b/builtin/sparse-checkout.c @@ -500,6 +500,8 @@ static int sparse_checkout_init(int argc, const char **argv, const char *prefix) return 0; } + free(sparse_filename); + add_pattern("/*", empty_base, 0, &pl, 0); add_pattern("!/*/", empty_base, 0, &pl, 0); pl.use_cone_patterns = init_opts.cone_mode;