From: Maciej S. Szmigiero Date: Tue, 29 Oct 2024 14:58:15 +0000 (+0100) Subject: migration/multifd: Zero p->flags before starting filling a packet X-Git-Tag: v9.2.0-rc0~26^2 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=00b4b216534d84ace7b0583cec70a3aaf256cb25;p=thirdparty%2Fqemu.git migration/multifd: Zero p->flags before starting filling a packet This way there aren't stale flags there. p->flags can't contain SYNC to be sent at the next RAM packet since syncs are now handled separately in multifd_send_thread. Reviewed-by: Fabiano Rosas Reviewed-by: Peter Xu Signed-off-by: Maciej S. Szmigiero Link: https://lore.kernel.org/r/1c96b6cdb797e6f035eb1a4ad9bfc24f4c7f5df8.1730203967.git.maciej.szmigiero@oracle.com Signed-off-by: Peter Xu --- diff --git a/migration/multifd.c b/migration/multifd.c index 697fe86fdf6..4374e14a965 100644 --- a/migration/multifd.c +++ b/migration/multifd.c @@ -600,6 +600,7 @@ static void *multifd_send_thread(void *opaque) * qatomic_store_release() in multifd_send(). */ if (qatomic_load_acquire(&p->pending_job)) { + p->flags = 0; p->iovs_num = 0; assert(!multifd_payload_empty(p->data)); @@ -651,7 +652,6 @@ static void *multifd_send_thread(void *opaque) } /* p->next_packet_size will always be zero for a SYNC packet */ stat64_add(&mig_stats.multifd_bytes, p->packet_len); - p->flags = 0; } qatomic_set(&p->pending_sync, false);