From: Philippe Blain Date: Sun, 21 Jan 2024 03:38:33 +0000 (+0000) Subject: ci(github): also skip logs of broken test cases X-Git-Tag: v2.44.0-rc0~38^2 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=0188b2c8e015d0bb1b39bc396d38f3b73f2f8c34;p=thirdparty%2Fgit.git ci(github): also skip logs of broken test cases When a test fails in the GitHub Actions CI pipeline, we mark it up using special GitHub syntax so it stands out when looking at the run log. We also mark up "fixed" test cases, and skip passing tests since we want to concentrate on the failures. The finalize_test_case_output function in test-lib-github-workflow-markup.sh which performs this markup is however missing a fourth case: "broken" tests, i.e. tests using 'test_expect_failure' to document a known bug. This leads to these "broken" tests appearing along with any failed tests, potentially confusing the reader who might not be aware that "broken" is the status for 'test_expect_failure' tests that indeed failed, and wondering what their commits "broke". Also skip these "broken" tests so that only failures and fixed tests stand out. Signed-off-by: Philippe Blain Acked-by: Victoria Dye Signed-off-by: Junio C Hamano --- diff --git a/t/test-lib-github-workflow-markup.sh b/t/test-lib-github-workflow-markup.sh index 9c5339c577..f9c2a0fb8d 100644 --- a/t/test-lib-github-workflow-markup.sh +++ b/t/test-lib-github-workflow-markup.sh @@ -42,8 +42,8 @@ finalize_test_case_output () { fixed) echo >>$github_markup_output "::notice::fixed: $this_test.$test_count $1" ;; - ok) - # Exit without printing the "ok" tests + ok|broken) + # Exit without printing the "ok" or ""broken" tests return ;; esac