From: Emeric Brun <ebrun@haproxy.com>
Date: Wed, 30 Jun 2021 14:24:04 +0000 (+0200)
Subject: BUG/MINOR: stick-table: fix several printf sign errors dumping tables
X-Git-Tag: v2.5-dev2~52
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=01928ae56b0296e5312eca195a4e155d6e8d79d0;p=thirdparty%2Fhaproxy.git

BUG/MINOR: stick-table: fix several printf sign errors dumping tables

This patch fixes several errors printing integers
of stick table entry values and args during dump on cli.

This patch should be backported since the dump of entries
is supported.  [wt: roughly 1.5-dev1 hence all stable branches]
---

diff --git a/src/stick_table.c b/src/stick_table.c
index fbfbc4a8c7..b1873f0769 100644
--- a/src/stick_table.c
+++ b/src/stick_table.c
@@ -3615,7 +3615,7 @@ static int table_dump_entry_to_buffer(struct buffer *msg,
 		if (t->data_ofs[dt] == 0)
 			continue;
 		if (stktable_data_types[dt].arg_type == ARG_T_DELAY)
-			chunk_appendf(msg, " %s(%d)=", stktable_data_types[dt].name, t->data_arg[dt].u);
+			chunk_appendf(msg, " %s(%u)=", stktable_data_types[dt].name, t->data_arg[dt].u);
 		else
 			chunk_appendf(msg, " %s=", stktable_data_types[dt].name);
 
@@ -3628,10 +3628,10 @@ static int table_dump_entry_to_buffer(struct buffer *msg,
 			chunk_appendf(msg, "%u", stktable_data_cast(ptr, std_t_uint));
 			break;
 		case STD_T_ULL:
-			chunk_appendf(msg, "%lld", stktable_data_cast(ptr, std_t_ull));
+			chunk_appendf(msg, "%llu", stktable_data_cast(ptr, std_t_ull));
 			break;
 		case STD_T_FRQP:
-			chunk_appendf(msg, "%d",
+			chunk_appendf(msg, "%u",
 				     read_freq_ctr_period(&stktable_data_cast(ptr, std_t_frqp),
 							  t->data_arg[dt].u));
 			break;