From: Vladimir Mezentsev <vladimir.mezentsev@oracle.com>
Date: Thu, 14 Dec 2023 01:52:15 +0000 (-0800)
Subject: gprofng: fix -Wuse-after-free warning
X-Git-Tag: binutils-2_42~576
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=01b386b55ecadcfce98896b9214edcd1e6fe0e62;p=thirdparty%2Fbinutils-gdb.git

gprofng: fix -Wuse-after-free warning

Removed incorrect unnecessary code.

gprofng/ChangeLog
2023-12-13  Vladimir Mezentsev  <vladimir.mezentsev@oracle.com>

	* src/collctrl.cc (set_synctrace): Fix -Wuse-after-free warning.
---

diff --git a/gprofng/src/collctrl.cc b/gprofng/src/collctrl.cc
index 5d68b689a64..aeff5a0336c 100644
--- a/gprofng/src/collctrl.cc
+++ b/gprofng/src/collctrl.cc
@@ -1081,10 +1081,6 @@ Coll_Ctrl::set_synctrace (const char *string)
   if (*endchar != 0 || tval < 0)
     {
       free (val);
-      /* invalid setting */
-      /* restore the comma, if it was zeroed out */
-      if (comma_p != NULL)
-	*comma_p = ',';
       return dbe_sprintf (GTXT ("Unrecognized synchronization tracing threshold `%s'\n"), string);
     }
   free (val);