From: Mathieu Malaterre Date: Mon, 14 Jan 2019 20:36:33 +0000 (+0100) Subject: genirq: Correctly annotate implicit fall through X-Git-Tag: v5.1-rc1~169^2~15 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=01cdfa912f1004c463586f52f1dfcbec1274b1f2;p=thirdparty%2Fkernel%2Flinux.git genirq: Correctly annotate implicit fall through There is a plan to build the kernel with -Wimplicit-fallthrough. The fallthrough in __handle_irq_event_percpu() has a fallthrough annotation which is followed by an additional comment and is not recognized by GCC. Separate the 'fall through' and the rest of the comment with a dash so the regular expression used by GCC matches. Signed-off-by: Mathieu Malaterre Signed-off-by: Thomas Gleixner Link: https://lkml.kernel.org/r/20190114203633.18557-1-malat@debian.org --- diff --git a/kernel/irq/handle.c b/kernel/irq/handle.c index 38554bc353755..6df5ddfdb0f8a 100644 --- a/kernel/irq/handle.c +++ b/kernel/irq/handle.c @@ -166,7 +166,7 @@ irqreturn_t __handle_irq_event_percpu(struct irq_desc *desc, unsigned int *flags __irq_wake_thread(desc, action); - /* Fall through to add to randomness */ + /* Fall through - to add to randomness */ case IRQ_HANDLED: *flags |= action->flags; break;