From: Dan Carpenter <dan.carpenter@linaro.org>
Date: Wed, 12 Mar 2025 08:31:57 +0000 (+0300)
Subject: platform/x86/amd/pmc: fix leak in probe()
X-Git-Tag: v6.15-rc1~172^2~4
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=01db3d1ff43aeedeaf11c8bc9d09493ec00c8f4a;p=thirdparty%2Fkernel%2Flinux.git

platform/x86/amd/pmc: fix leak in probe()

Call pci_dev_put(rdev) before returning.

Fixes: 6ad1b2dc0f2a ("platform/x86/amd/pmc: Use managed APIs for mutex")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Link: https://lore.kernel.org/r/65e2fffb-a1cb-4297-b725-661d6b790a05@stanley.mountain
Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
---

diff --git a/drivers/platform/x86/amd/pmc/pmc.c b/drivers/platform/x86/amd/pmc/pmc.c
index 84bc47009e5f9..d789d6cab7948 100644
--- a/drivers/platform/x86/amd/pmc/pmc.c
+++ b/drivers/platform/x86/amd/pmc/pmc.c
@@ -785,7 +785,7 @@ static int amd_pmc_probe(struct platform_device *pdev)
 
 	err = devm_mutex_init(dev->dev, &dev->lock);
 	if (err)
-		return err;
+		goto err_pci_dev_put;
 
 	/* Get num of IP blocks within the SoC */
 	amd_pmc_get_ip_info(dev);