From: William Lallemand <wlallemand@haproxy.org>
Date: Fri, 14 Jan 2022 16:59:01 +0000 (+0100)
Subject: BUG/MINOR: httpclient/lua: don't pop the lua stack when getting headers
X-Git-Tag: v2.6-dev1~128
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=01e2be84d746c5203f7c5723bb6ca9e469026c3d;p=thirdparty%2Fhaproxy.git

BUG/MINOR: httpclient/lua: don't pop the lua stack when getting headers

hlua_httpclient_table_to_hdrs() does a lua_pop(L, 1) at the end of the
function, this is supposed to be done in the caller and it is already be
done in hlua_httpclient_send().

This call has the consequence of poping the next parameter of the
httpclient, ignoring it.

This patch fixes the issue by removing the lua_pop(L, 1).

Must be backported in 2.5.
---

diff --git a/src/hlua.c b/src/hlua.c
index 8dea91e758..8da64eed67 100644
--- a/src/hlua.c
+++ b/src/hlua.c
@@ -7097,7 +7097,6 @@ struct http_hdr *hlua_httpclient_table_to_hdrs(lua_State *L)
 	}
 
 skip_headers:
-	lua_pop(L, 1);
 
 	return result;
 }