From: Dan Carpenter <dan.carpenter@linaro.org>
Date: Fri, 14 Mar 2025 10:11:43 +0000 (+0300)
Subject: ASoC: amd: acp: Fix leak in acp_pci_probe()
X-Git-Tag: v6.15-rc1~173^2~4^2~23
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=02026aabaa8225bd7dfdcb8ae106453e002cb0a8;p=thirdparty%2Fkernel%2Flinux.git

ASoC: amd: acp: Fix leak in acp_pci_probe()

There needs to be some cleanup on this error path.  We can't just
return directly.

Fixes: aaf7a668bb38 ("ASoC: amd: acp: Add new interrupt handle callbacks in acp_common_hw_ops")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Link: https://patch.msgid.link/3dad80cb-e177-45aa-97ac-df9c98a47d94@stanley.mountain
Signed-off-by: Mark Brown <broonie@kernel.org>
---

diff --git a/sound/soc/amd/acp/acp-pci.c b/sound/soc/amd/acp/acp-pci.c
index 9322379cb36fc..123524f90d6c4 100644
--- a/sound/soc/amd/acp/acp-pci.c
+++ b/sound/soc/amd/acp/acp-pci.c
@@ -183,7 +183,7 @@ static int acp_pci_probe(struct pci_dev *pci, const struct pci_device_id *pci_id
 			       IRQF_SHARED, "ACP_I2S_IRQ", chip);
 	if (ret) {
 		dev_err(&pci->dev, "ACP I2S IRQ request failed %d\n", ret);
-		return ret;
+		goto de_init;
 	}
 
 	check_acp_config(pci, chip);