From: Daniel Stenberg <daniel@haxx.se>
Date: Sat, 20 Sep 2025 09:31:54 +0000 (+0200)
Subject: tool_cb_hdr: size is always 1
X-Git-Tag: rc-8_17_0-1~324
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=0209e087c6989d7b6df49d3e090414eeccdda8ef;p=thirdparty%2Fcurl.git

tool_cb_hdr: size is always 1

- add comment in the header that the argument 'size' is always 1,
  as guaranteed by the libcurl API

- then fix the call to fwrite() to avoid using "size, etag_length" which
  would be wrong if size was something else than 1, and use a fixed
  number there instead.

Reported in Joshua's sarif data

Closes #18630
---

diff --git a/src/tool_cb_hdr.c b/src/tool_cb_hdr.c
index 3bb3c12dc8..7781e4dc3c 100644
--- a/src/tool_cb_hdr.c
+++ b/src/tool_cb_hdr.c
@@ -81,6 +81,8 @@ fail:
 
 /*
 ** callback for CURLOPT_HEADERFUNCTION
+*
+* 'size' is always 1
 */
 size_t tool_header_cb(char *ptr, size_t size, size_t nmemb, void *userdata)
 {
@@ -164,7 +166,7 @@ size_t tool_header_cb(char *ptr, size_t size, size_t nmemb, void *userdata)
           }
 #endif
 
-          fwrite(etag_h, size, etag_length, etag_save->stream);
+          fwrite(etag_h, 1, etag_length, etag_save->stream);
           /* terminate with newline */
           fputc('\n', etag_save->stream);
           (void)fflush(etag_save->stream);