From: Steve French <stfrench@microsoft.com>
Date: Tue, 16 Nov 2021 03:00:08 +0000 (-0600)
Subject: cifs: move debug print out of spinlock
X-Git-Tag: v5.16-rc2~9^2~2
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=0226487ad8146433be74d20955448e12d85fd251;p=thirdparty%2Flinux.git

cifs: move debug print out of spinlock

It is better to print debug messages outside of the chan_lock
spinlock where possible.

Reviewed-by: Shyam Prasad N <sprasad@microsoft.com>
Addresses-Coverity: 1493854 ("Thread deadlock")
Reviewed-by: Paulo Alcantara (SUSE) <pc@cjr.nz>
Signed-off-by: Steve French <stfrench@microsoft.com>
---

diff --git a/fs/cifs/sess.c b/fs/cifs/sess.c
index 2c10b186ed6ee..7db8b22edac98 100644
--- a/fs/cifs/sess.c
+++ b/fs/cifs/sess.c
@@ -95,9 +95,9 @@ int cifs_try_adding_channels(struct cifs_sb_info *cifs_sb, struct cifs_ses *ses)
 	}
 
 	if (!(ses->server->capabilities & SMB2_GLOBAL_CAP_MULTI_CHANNEL)) {
-		cifs_dbg(VFS, "server %s does not support multichannel\n", ses->server->hostname);
 		ses->chan_max = 1;
 		spin_unlock(&ses->chan_lock);
+		cifs_dbg(VFS, "server %s does not support multichannel\n", ses->server->hostname);
 		return 0;
 	}
 	spin_unlock(&ses->chan_lock);