From: Luca Ceresoli Date: Tue, 5 Nov 2019 14:08:54 +0000 (+0100) Subject: genirq: Show irq name in non-oneshot error message X-Git-Tag: v5.6-rc1~175^2~4 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=025af39b87dc4dc78de4e861ca8b88a1d5ba89f6;p=thirdparty%2Fkernel%2Flinux.git genirq: Show irq name in non-oneshot error message Requesting a threaded IRQ with handler=NULL and !ONESHOT fails, but the error message does not include the IRQ line name, which makes it harder to find the offending driver. Print the IRQ line name to clarify where the error comes from. Use the same format as the other pr_err() above in the same function. Signed-off-by: Luca Ceresoli Signed-off-by: Thomas Gleixner Link: https://lore.kernel.org/r/20191105140854.27893-1-luca@lucaceresoli.net --- diff --git a/kernel/irq/manage.c b/kernel/irq/manage.c index 1753486b440cb..b6c53ab053d2f 100644 --- a/kernel/irq/manage.c +++ b/kernel/irq/manage.c @@ -1500,8 +1500,8 @@ __setup_irq(unsigned int irq, struct irq_desc *desc, struct irqaction *new) * has. The type flags are unreliable as the * underlying chip implementation can override them. */ - pr_err("Threaded irq requested with handler=NULL and !ONESHOT for irq %d\n", - irq); + pr_err("Threaded irq requested with handler=NULL and !ONESHOT for %s (irq %d)\n", + new->name, irq); ret = -EINVAL; goto out_unlock; }