From: Eric Sandeen <sandeen@sandeen.net>
Date: Mon, 30 May 2016 00:35:56 +0000 (+1000)
Subject: xfs_db: defang frag command
X-Git-Tag: v4.7.0-rc1~30
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=027e6efd2b432232562d726f14702f79792b38cb;p=thirdparty%2Fxfsprogs-dev.git

xfs_db: defang frag command

Too many people freak out about this fictitious "fragmentation
factor."  As shown in the fact, it is largely meaningless, because
the number approaches 100% extremely quickly for just a few
extents per file.

I thought about removing it altogether, but perhaps a note
about its uselessness, and a more soothing metric (avg extents
per file) might be useful.

Signed-off-by: Eric Sandeen <sandeen@redhat.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Dave Chinner <david@fromorbit.com>
---

diff --git a/db/frag.c b/db/frag.c
index 36bb6895b..e11b140b2 100644
--- a/db/frag.c
+++ b/db/frag.c
@@ -172,6 +172,10 @@ frag_f(
 		answer = 0.0;
 	dbprintf(_("actual %llu, ideal %llu, fragmentation factor %.2f%%\n"),
 		extcount_actual, extcount_ideal, answer);
+	dbprintf(_("Note, this number is largely meaningless.\n"));
+	answer = (double)extcount_actual / (double)extcount_ideal;
+	dbprintf(_("Files on this filesystem average %.2f extents per file\n"),
+		answer);
 	return 0;
 }