From: Vladimir Oltean Date: Thu, 21 Aug 2025 15:20:17 +0000 (+0300) Subject: net: phy: aquantia: call aqr_gen2_fill_interface_modes() for AQCS109 X-Git-Tag: v6.18-rc1~132^2~353^2~5 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=02a7f5a92545ef99fc503fd8a86a686d29ce0974;p=thirdparty%2Fkernel%2Fstable.git net: phy: aquantia: call aqr_gen2_fill_interface_modes() for AQCS109 I don't have documentation or hardware to test, but according to commit 99c864667c9f ("net: phy: aquantia: add support for AQCS109"), "From software point of view, it should be almost equivalent to AQR107." I am relatively confident that the GLOBAL_CFG registers read by aqr_gen2_fill_interface_modes() are supported, because aqr_gen2_read_status(), currently used by AQCS109, also reads them, and I'm unaware of any reported problem. The change is necessary because a future patch will introduce a requirement for all aqr_gen2_read_status() callers to have previously called aqr_gen2_read_global_syscfg(). This is done through aqr_gen2_fill_interface_modes(). Cc: Nikita Yushchenko Signed-off-by: Vladimir Oltean Link: https://patch.msgid.link/20250821152022.1065237-11-vladimir.oltean@nxp.com Signed-off-by: Jakub Kicinski --- diff --git a/drivers/net/phy/aquantia/aquantia_main.c b/drivers/net/phy/aquantia/aquantia_main.c index e3a18fc1b52ae..a7b1862e8a26f 100644 --- a/drivers/net/phy/aquantia/aquantia_main.c +++ b/drivers/net/phy/aquantia/aquantia_main.c @@ -899,7 +899,11 @@ static int aqcs109_config_init(struct phy_device *phydev) if (!ret) aqr107_chip_info(phydev); - return aqr107_set_downshift(phydev, MDIO_AN_VEND_PROV_DOWNSHIFT_DFLT); + ret = aqr107_set_downshift(phydev, MDIO_AN_VEND_PROV_DOWNSHIFT_DFLT); + if (ret) + return ret; + + return aqr_gen2_fill_interface_modes(phydev); } static void aqr107_link_change_notify(struct phy_device *phydev)