From: Tom Tromey <tromey@adacore.com>
Date: Thu, 11 Apr 2019 19:00:48 +0000 (-0600)
Subject: Make "msg" const in internal_vproblem
X-Git-Tag: binutils-2_33~1591
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=02cf60c7a42710ee0364698c436b6ca5e771374b;p=thirdparty%2Fbinutils-gdb.git

Make "msg" const in internal_vproblem

I noticed that the "msg" variable in internal_vproblem could be
"const".  This seems like an improvement because it can wind up in
rodata.

Tested by rebuilding.

gdb/ChangeLog
2019-04-11  Tom Tromey  <tromey@adacore.com>

	* utils.c (internal_vproblem): Make "msg" const.
---

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index a5cbc899729..7428ed9730f 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,7 @@
+2019-04-11  Tom Tromey  <tromey@adacore.com>
+
+	* utils.c (internal_vproblem): Make "msg" const.
+
 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
 
 	* aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
diff --git a/gdb/utils.c b/gdb/utils.c
index 840779a6307..700f54f9ad3 100644
--- a/gdb/utils.c
+++ b/gdb/utils.c
@@ -300,7 +300,7 @@ internal_vproblem (struct internal_problem *problem,
 
   /* Don't allow infinite error/warning recursion.  */
   {
-    static char msg[] = "Recursive internal problem.\n";
+    static const char msg[] = "Recursive internal problem.\n";
 
     switch (dejavu)
       {