From: Christopher Faulet Date: Tue, 30 Apr 2019 12:08:41 +0000 (+0200) Subject: CLEANUP: config: Don't alter listener->maxaccept when nbproc is set to 1 X-Git-Tag: v2.0-dev3~141 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=02f3cf19ed803d20aff9294ce7cb732489951ff5;p=thirdparty%2Fhaproxy.git CLEANUP: config: Don't alter listener->maxaccept when nbproc is set to 1 This patch only removes a useless calculation on listener->maxaccept when nbproc is set to 1. Indeed, the following formula has no effet in such case: listener->maxaccept = (listener->maxaccept + nbproc - 1) / nbproc; This patch may be backported as far as 1.5. --- diff --git a/src/cfgparse.c b/src/cfgparse.c index 9a03a02bba..48d53e9dd4 100644 --- a/src/cfgparse.c +++ b/src/cfgparse.c @@ -3728,9 +3728,8 @@ out_uri_auth_compat: * is bound to. Rememeber that maxaccept = -1 must be kept as it is * used to disable the limit. */ - if (listener->maxaccept > 0) { - if (nbproc > 1) - listener->maxaccept = (listener->maxaccept + 1) / 2; + if (listener->maxaccept > 0 && nbproc > 1) { + listener->maxaccept = (listener->maxaccept + 1) / 2; listener->maxaccept = (listener->maxaccept + nbproc - 1) / nbproc; }