From: Nicholas Piggin <npiggin@gmail.com>
Date: Tue, 6 Aug 2024 13:13:13 +0000 (+1000)
Subject: target/ppc: Fix mtDPDES targeting SMT siblings
X-Git-Tag: v9.2.0-rc0~22^2~62
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=0324d236d2918c18a9ad4a1081b1083965a1433b;p=thirdparty%2Fqemu.git

target/ppc: Fix mtDPDES targeting SMT siblings

A typo in the loop over SMT threads to set irq level for doorbells
when storing to DPDES meant everything was aimed at the CPU executing
the instruction.

Cc: qemu-stable@nongnu.org
Fixes: d24e80b2ae ("target/ppc: Add msgsnd/p and DPDES SMT support")
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Nicholas Piggin <npiggin@gmail.com>
---

diff --git a/target/ppc/misc_helper.c b/target/ppc/misc_helper.c
index 1b839713753..f0ca80153b2 100644
--- a/target/ppc/misc_helper.c
+++ b/target/ppc/misc_helper.c
@@ -288,7 +288,7 @@ void helper_store_dpdes(CPUPPCState *env, target_ulong val)
         PowerPCCPU *ccpu = POWERPC_CPU(ccs);
         uint32_t thread_id = ppc_cpu_tir(ccpu);
 
-        ppc_set_irq(cpu, PPC_INTERRUPT_DOORBELL, val & (0x1 << thread_id));
+        ppc_set_irq(ccpu, PPC_INTERRUPT_DOORBELL, val & (0x1 << thread_id));
     }
     bql_unlock();
 }