From: Andrew Burgess <aburgess@redhat.com>
Date: Mon, 8 Apr 2024 11:34:39 +0000 (+0100)
Subject: gdb/data-directory: silence output from mkinstalldirs script
X-Git-Tag: gdb-15-branchpoint~421
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=032e5e0c0c08977e8109e8482cd944bac8572d92;p=thirdparty%2Fbinutils-gdb.git

gdb/data-directory: silence output from mkinstalldirs script

After my recent changes the data-directory build now uses
silent-rules.mk to reduce the output.

One problem that remains was the use of mkinstalldirs by stamp-python
and stamp-guile for creating some directories, the mkinstalldirs
prints some messages, so we're left with output like this:

    GEN    stamp-python
  mkdir -p -- ./python/gdb
  mkdir -p -- ./python/gdb/command
  mkdir -p -- ./python/gdb/dap
  mkdir -p -- ./python/gdb/function
  mkdir -p -- ./python/gdb/printer

I was looking at adding a --silent option to the mkinstalldirs script,
however, when I took a look at the automake package (which is where
mkinstalldirs comes from) it turns out that mkinstalldirs is
deprecated, at the advice is to use 'install-sh -d' instead.

Just like we carry mkinstalldirs in the top-level directory, we also
carry install-sh, and a version of install-sh which supports the -d
flag.

And best of all, 'install-sh -d' doesn't appear to print any of the
information messages to stdout that mkinstalldirs does, so if we
switch to use that, we get a quieter build.

There should be no changes in what is built after this commit

Approved-By: Tom Tromey <tom@tromey.com>
---

diff --git a/gdb/data-directory/Makefile.in b/gdb/data-directory/Makefile.in
index c0419df86b3..98a43529b07 100644
--- a/gdb/data-directory/Makefile.in
+++ b/gdb/data-directory/Makefile.in
@@ -44,7 +44,7 @@ LN_S = @LN_S@
 
 INSTALL = @INSTALL@
 INSTALL_DATA = @INSTALL_DATA@
-INSTALL_DIR = $(SHELL) $(srcdir)/../../mkinstalldirs
+INSTALL_DIR = $(SHELL) $(srcdir)/../../install-sh -d
 
 GDB_DATADIR = @GDB_DATADIR@