From: Jakub Jelinek Date: Tue, 30 Dec 2008 23:34:28 +0000 (+0100) Subject: re PR middle-end/38505 (Revision 142061 caused ICE on __builtin_memcpy) X-Git-Tag: releases/gcc-4.4.0~1092 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=03375368aeef4d02b5b987cd83175cfcfb925e12;p=thirdparty%2Fgcc.git re PR middle-end/38505 (Revision 142061 caused ICE on __builtin_memcpy) PR middle-end/38505 * tree-ssa-ccp.c (may_propagate_address_into_dereference): Return false if ADDR's operand has incomplete type. Revert: 2008-12-15 Jakub Jelinek PR middle-end/38505 * tree-ssa.c (useless_type_conversion_p_1): Return false if inner_type is incomplete and outer_type is complete. From-SVN: r142972 --- diff --git a/gcc/ChangeLog b/gcc/ChangeLog index adff086bd0d0..ab6a187530ca 100644 --- a/gcc/ChangeLog +++ b/gcc/ChangeLog @@ -1,3 +1,15 @@ +2008-12-31 Jakub Jelinek + + PR middle-end/38505 + * tree-ssa-ccp.c (may_propagate_address_into_dereference): Return + false if ADDR's operand has incomplete type. + + Revert: + 2008-12-15 Jakub Jelinek + PR middle-end/38505 + * tree-ssa.c (useless_type_conversion_p_1): Return + false if inner_type is incomplete and outer_type is complete. + 2008-12-31 Jakub Jelinek PR middle-end/38676 diff --git a/gcc/tree-ssa-ccp.c b/gcc/tree-ssa-ccp.c index d68337fc402a..d0fcf3937a73 100644 --- a/gcc/tree-ssa-ccp.c +++ b/gcc/tree-ssa-ccp.c @@ -860,6 +860,10 @@ may_propagate_address_into_dereference (tree addr, tree deref) gcc_assert (INDIRECT_REF_P (deref) && TREE_CODE (addr) == ADDR_EXPR); + /* Don't propagate if ADDR's operand has incomplete type. */ + if (!COMPLETE_TYPE_P (TREE_TYPE (TREE_OPERAND (addr, 0)))) + return false; + /* If the address is invariant then we do not need to preserve restrict qualifications. But we do need to preserve volatile qualifiers until we can annotate the folded dereference itself properly. */ diff --git a/gcc/tree-ssa.c b/gcc/tree-ssa.c index ce0f1e4ee67b..935cad676c14 100644 --- a/gcc/tree-ssa.c +++ b/gcc/tree-ssa.c @@ -1188,11 +1188,6 @@ useless_type_conversion_p_1 (tree outer_type, tree inner_type) if (TREE_CODE (inner_type) != TREE_CODE (outer_type)) return false; - /* Conversion from an incomplete to a complete type is never - useless. */ - if (!COMPLETE_TYPE_P (inner_type) && COMPLETE_TYPE_P (outer_type)) - return false; - /* ??? This seems to be necessary even for aggregates that don't have TYPE_STRUCTURAL_EQUALITY_P set. */