From: Stefan Schantl <stefan.schantl@ipfire.org>
Date: Wed, 8 Jan 2020 11:12:29 +0000 (+0100)
Subject: dns.cgi: Check for empty server address.
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=038f962ea0555c132287db4c20f83800becf846f;p=people%2Fstevee%2Fipfire-2.x.git

dns.cgi: Check for empty server address.

Signed-off-by: Stefan Schantl <stefan.schantl@ipfire.org>
---

diff --git a/html/cgi-bin/dns.cgi b/html/cgi-bin/dns.cgi
index 4fecd342c7..4498a71a3e 100755
--- a/html/cgi-bin/dns.cgi
+++ b/html/cgi-bin/dns.cgi
@@ -95,8 +95,13 @@ if (($cgiparams{'SERVERS'} eq $Lang::tr{'save'}) || ($cgiparams{'SERVERS'} eq $L
 	# Read-in generic settings.
 	&General::readhash("$settings_file", \%settings);
 
+	# Check if an IP-address has been given.
+	if ($cgiparams{"NAMESERVER"} eq "") {
+		$errormessage = "$Lang::tr{'dns no address given'}";
+	}
+
 	# Check if the given DNS server is valid.
-	if(!&General::validip($cgiparams{"NAMESERVER"})) {
+	elsif(!&General::validip($cgiparams{"NAMESERVER"})) {
 		$errormessage = "$Lang::tr{'invalid ip'}: $cgiparams{'NAMESERVER'}";
 	}
 
diff --git a/langs/en/cgi-bin/en.pl b/langs/en/cgi-bin/en.pl
index 4542cad163..fdfae84346 100644
--- a/langs/en/cgi-bin/en.pl
+++ b/langs/en/cgi-bin/en.pl
@@ -857,6 +857,7 @@
 'dns mode for qname minimisation' => 'QNAME Minimisation',
 'dns new 0' => 'New <strong>primary</strong> DNS server IP:',
 'dns new 1' => 'New <strong>secondary</strong> DNS server IP:',
+'dns no address given' => 'No IP Address given.',
 'dns no tls hostname given' => 'No TLS hostname given.',
 'dns proxy server' => 'DNS Proxy Server',
 'dns saved' => 'Successfully saved!',