From: Chandra Pratap Date: Thu, 28 Dec 2023 08:01:00 +0000 (+0000) Subject: sideband.c: remove redundant 'NEEDSWORK' tag X-Git-Tag: v2.43.1~3^2 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=03bcc93769bd5e3b14094c36e3d466587f922274;p=thirdparty%2Fgit.git sideband.c: remove redundant 'NEEDSWORK' tag Signed-off-by: Chandra Pratap Signed-off-by: Junio C Hamano --- diff --git a/sideband.c b/sideband.c index 85bddfdcd4..cdbe0789f0 100644 --- a/sideband.c +++ b/sideband.c @@ -66,7 +66,10 @@ void list_config_color_sideband_slots(struct string_list *list, const char *pref * of the line. This should be called for a single line only, which is * passed as the first N characters of the SRC array. * - * NEEDSWORK: use "size_t n" instead for clarity. + * It is fine to use "int n" here instead of "size_t n" as all calls to this + * function pass an 'int' parameter. Additionally, the buffer involved in + * storing these 'int' values takes input from a packet via the pkt-line + * interface, which is capable of transferring only 64kB at a time. */ static void maybe_colorize_sideband(struct strbuf *dest, const char *src, int n) {