From: Rongrong Zou Date: Mon, 31 Oct 2016 11:59:56 +0000 (+0800) Subject: drm: update the documentation of drm_framebuffer_unregister_private X-Git-Tag: v4.10-rc1~154^2~36^2~30 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=03e93ac756915e2cb3b7a8469b61a88949ac7a1c;p=thirdparty%2Fkernel%2Flinux.git drm: update the documentation of drm_framebuffer_unregister_private Add obvious description to drm_framebuffer_unregister_private() to explain it is deprecated. Signed-off-by: Rongrong Zou Signed-off-by: Daniel Vetter Link: http://patchwork.freedesktop.org/patch/msgid/1477915196-100299-1-git-send-email-zourongrong@gmail.com --- diff --git a/drivers/gpu/drm/drm_framebuffer.c b/drivers/gpu/drm/drm_framebuffer.c index 49fd7db758e02..af786f27f72ec 100644 --- a/drivers/gpu/drm/drm_framebuffer.c +++ b/drivers/gpu/drm/drm_framebuffer.c @@ -673,6 +673,11 @@ EXPORT_SYMBOL(drm_framebuffer_lookup); * those used for fbdev. Note that the caller must hold a reference of it's own, * i.e. the object may not be destroyed through this call (since it'll lead to a * locking inversion). + * + * NOTE: This function is deprecated. For driver-private framebuffers it is not + * recommended to embed a framebuffer struct info fbdev struct, instead, a + * framebuffer pointer is preferred and drm_framebuffer_unreference() should be + * called when the framebuffer is to be cleaned up. */ void drm_framebuffer_unregister_private(struct drm_framebuffer *fb) {