From: H.J. Lu Date: Fri, 8 Mar 2024 16:08:02 +0000 (-0800) Subject: gas: Fix x86 build with GCC 6.4 X-Git-Tag: gdb-15-branchpoint~778 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=03fa0c63d3a5944afcf031ecf0b433b2985e6eeb;p=thirdparty%2Fbinutils-gdb.git gas: Fix x86 build with GCC 6.4 Add "()" to silence GCC 6.4: .../gas/config/tc-i386.c: In function ‘x86_ginsn_lea’: .../gas/config/tc-i386.c:5738:19: error: logical not is only applied to the left hand side of comparison [-Werror=logical-not-parentheses] if (!i.base_reg != (!i.index_reg || i.index_reg->reg_num == RegIZ)) ^~ cc1: all warnings being treated as errors PR gas/31464 * config/tc-i386.c (x86_ginsn_lea): Add "()" to silence GCC 6.4. --- diff --git a/gas/config/tc-i386.c b/gas/config/tc-i386.c index fecb25a3fe2..532f8f58b0a 100644 --- a/gas/config/tc-i386.c +++ b/gas/config/tc-i386.c @@ -5735,7 +5735,7 @@ x86_ginsn_lea (const symbolS *insn_end_sym) unsigned int dst_reg; bool index_regiz_p; - if (!i.base_reg != (!i.index_reg || i.index_reg->reg_num == RegIZ)) + if ((!i.base_reg) != (!i.index_reg || i.index_reg->reg_num == RegIZ)) { /* lea disp(%base), %dst or lea disp(,%index,imm), %dst. Either index_reg or base_reg exists, but not both. Further, as per