From: Guenter Roeck Date: Sun, 7 Jul 2024 06:50:08 +0000 (-0700) Subject: hwmon: (nct6775-core) Fix underflows seen when writing limit attributes X-Git-Tag: v6.11-rc1~212^2~17 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=0403e10bf0824bf0ec2bb135d4cf1c0cc3bf4bf0;p=thirdparty%2Flinux.git hwmon: (nct6775-core) Fix underflows seen when writing limit attributes DIV_ROUND_CLOSEST() after kstrtol() results in an underflow if a large negative number such as -9223372036854775808 is provided by the user. Fix it by reordering clamp_val() and DIV_ROUND_CLOSEST() operations. Signed-off-by: Guenter Roeck --- diff --git a/drivers/hwmon/nct6775-core.c b/drivers/hwmon/nct6775-core.c index 9fbab8f023340..934fed3dd5866 100644 --- a/drivers/hwmon/nct6775-core.c +++ b/drivers/hwmon/nct6775-core.c @@ -2262,7 +2262,7 @@ store_temp_offset(struct device *dev, struct device_attribute *attr, if (err < 0) return err; - val = clamp_val(DIV_ROUND_CLOSEST(val, 1000), -128, 127); + val = DIV_ROUND_CLOSEST(clamp_val(val, -128000, 127000), 1000); mutex_lock(&data->update_lock); data->temp_offset[nr] = val;