From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Mon, 25 Sep 2017 10:21:33 +0000 (+0300)
Subject: spi: sprd-adi: checking for NULL instead of IS_ERR()
X-Git-Tag: v4.15-rc1~174^2^4~4
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=04063a011f2f35c37e1146c736e6d4ad402a8557;p=thirdparty%2Fkernel%2Flinux.git

spi: sprd-adi: checking for NULL instead of IS_ERR()

devm_ioremap_resource() returns error pointers, it never returns NULL.

Fixes: 7e2903cb91df ("spi: Add ADI driver for Spreadtrum platform")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
---

diff --git a/drivers/spi/spi-sprd-adi.c b/drivers/spi/spi-sprd-adi.c
index 0d481f8a46c20..bff6ef1caad77 100644
--- a/drivers/spi/spi-sprd-adi.c
+++ b/drivers/spi/spi-sprd-adi.c
@@ -341,8 +341,8 @@ static int sprd_adi_probe(struct platform_device *pdev)
 
 	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
 	sadi->base = devm_ioremap_resource(&pdev->dev, res);
-	if (!sadi->base) {
-		ret = -ENOMEM;
+	if (IS_ERR(sadi->base)) {
+		ret = PTR_ERR(sadi->base);
 		goto put_ctlr;
 	}