From: Jiri Slaby Date: Fri, 19 Feb 2021 10:12:16 +0000 (+0100) Subject: media: atomisp: do not free kmalloc memory by vfree X-Git-Tag: v5.13-rc1~124^2~195 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=040b86483c63ef426ce0d6c0cd9f8352d3c2fdad;p=thirdparty%2Fkernel%2Flinux.git media: atomisp: do not free kmalloc memory by vfree fw_minibuffer[i].buffer is allocated by kmalloc in sh_css_load_blob_info and by vmalloc in setup_binary. So use kvfree to decide which of those allocators to use for freeing. Also remove the useless cast. Link: https://lore.kernel.org/linux-media/20210219101216.28406-1-jslaby@suse.cz Signed-off-by: Jiri Slaby Signed-off-by: Mauro Carvalho Chehab --- diff --git a/drivers/staging/media/atomisp/pci/sh_css_firmware.c b/drivers/staging/media/atomisp/pci/sh_css_firmware.c index db25e39bea886..f4ce8ace9d509 100644 --- a/drivers/staging/media/atomisp/pci/sh_css_firmware.c +++ b/drivers/staging/media/atomisp/pci/sh_css_firmware.c @@ -366,7 +366,7 @@ void sh_css_unload_firmware(void) if (fw_minibuffer[i].name) kfree((void *)fw_minibuffer[i].name); if (fw_minibuffer[i].buffer) - vfree((void *)fw_minibuffer[i].buffer); + kvfree(fw_minibuffer[i].buffer); } kfree(fw_minibuffer); fw_minibuffer = NULL;