From: Peter Maydell Date: Mon, 22 Sep 2025 09:37:01 +0000 (+0100) Subject: contrib/plugins/execlog: Explicitly check for qemu_plugin_read_register() failure X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=04387b4a056771bf4a95b310507c8302f12c4b65;p=thirdparty%2Fqemu.git contrib/plugins/execlog: Explicitly check for qemu_plugin_read_register() failure In insn_check_regs() we don't explicitly check whether qemu_plugin_read_register() failed, which confuses Coverity into thinking that sz can be -1 in the memcmp(). In fact the assertion that sz == reg->last->len means this can't happen, but it's clearer to both humans and Coverity if we explicitly assert that sz > 0, as we already do in init_vcpu_register(). Coverity: CID 1611901, 1611902 Fixes: af6e4e0a22c1 ("contrib/plugins: extend execlog to track register changes") Signed-off-by: Peter Maydell Reviewed-by: Pierrick Bouvier Message-ID: <20250710144543.1187715-1-peter.maydell@linaro.org> Signed-off-by: Alex Bennée Message-ID: <20250922093711.2768983-17-alex.bennee@linaro.org> --- diff --git a/contrib/plugins/execlog.c b/contrib/plugins/execlog.c index 06ec76d6e9a..811f3203199 100644 --- a/contrib/plugins/execlog.c +++ b/contrib/plugins/execlog.c @@ -95,6 +95,7 @@ static void insn_check_regs(CPU *cpu) g_byte_array_set_size(reg->new, 0); sz = qemu_plugin_read_register(reg->handle, reg->new); + g_assert(sz > 0); g_assert(sz == reg->last->len); if (memcmp(reg->last->data, reg->new->data, sz)) {