From: Timo Sirainen <timo.sirainen@open-xchange.com>
Date: Thu, 16 Jan 2025 11:11:31 +0000 (+0200)
Subject: lib-settings: test-settings-parser - Avoid crashing on unit test failure
X-Git-Tag: 2.4.0~36
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=047f936ec7f14b0af84c90d03e24c79d4d3456a0;p=thirdparty%2Fdovecot%2Fcore.git

lib-settings: test-settings-parser - Avoid crashing on unit test failure

Also makes scan-build happy.
---

diff --git a/src/lib-settings/test-settings-parser.c b/src/lib-settings/test-settings-parser.c
index 2be78b9727..74642b399c 100644
--- a/src/lib-settings/test-settings-parser.c
+++ b/src/lib-settings/test-settings-parser.c
@@ -188,8 +188,13 @@ static void test_settings_parse_boollist_string(void)
 			pool_datastack_create(), &output, &error) == 0, i);
 		test_assert_idx(array_count(&output) == str_array_length(tests[i].output), i);
 		unsigned int j = 0;
-		array_foreach_elem(&output, value)
-			test_assert_strcmp_idx(tests[i].output[j++], value, i);
+		array_foreach_elem(&output, value) {
+			const char *next_output = NULL;
+			if (tests[i].output != NULL &&
+			    tests[i].output[j] != NULL)
+				next_output = tests[i].output[j++];
+			test_assert_strcmp_idx(next_output, value, i);
+		}
 	} T_END;
 
 	t_array_init(&output, 8);