From: Zhu Jun Date: Wed, 9 Oct 2024 06:53:45 +0000 (-0700) Subject: ALSA: ice1712: Remove redundant code in stac9460_dac_vol_put X-Git-Tag: v6.13-rc1~123^2~26 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=0498a04e399c6e720bb991db992174e19b2fe980;p=thirdparty%2Flinux.git ALSA: ice1712: Remove redundant code in stac9460_dac_vol_put The variable 'ovol' is never referenced in the code, just remove it. Signed-off-by: Zhu Jun Link: https://patch.msgid.link/20241009065345.6669-1-zhujun2@cmss.chinamobile.com Signed-off-by: Takashi Iwai --- diff --git a/sound/pci/ice1712/prodigy192.c b/sound/pci/ice1712/prodigy192.c index 096ec76f53046..a12dafbf53ab2 100644 --- a/sound/pci/ice1712/prodigy192.c +++ b/sound/pci/ice1712/prodigy192.c @@ -170,14 +170,9 @@ static int stac9460_dac_vol_put(struct snd_kcontrol *kcontrol, struct snd_ctl_el tmp = stac9460_get(ice, idx); ovol = 0x7f - (tmp & 0x7f); change = (ovol != nvol); - if (change) { - ovol = (0x7f - nvol) | (tmp & 0x80); - /* - dev_dbg(ice->card->dev, "DAC Volume: reg 0x%02x: 0x%02x\n", - idx, ovol); - */ + if (change) stac9460_put(ice, idx, (0x7f - nvol) | (tmp & 0x80)); - } + return change; }