From: William A. Rowe Jr <wrowe@apache.org>
Date: Fri, 29 Jul 2016 21:47:19 +0000 (+0000)
Subject: Correct logic, detect no 'token' chars, or missing ':'
X-Git-Tag: 2.5.0-alpha~1352
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=04a85817d0fb35238d7439af700645ac5337234d;p=thirdparty%2Fapache%2Fhttpd.git

Correct logic, detect no 'token' chars, or missing ':'

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1754577 13f79535-47bb-0310-9956-ffa450edef68
---

diff --git a/server/protocol.c b/server/protocol.c
index cef75175ba3..60be6fb12ae 100644
--- a/server/protocol.c
+++ b/server/protocol.c
@@ -946,7 +946,7 @@ AP_DECLARE(void) ap_get_mime_headers_core(request_rec *r, apr_bucket_brigade *bb
                 {
                     /* Ensure valid token chars before ':' per RFC 7230 3.2.4 */
                     value = (char *)ap_scan_http_token(last_field);
-                    if ((value > last_field) || *value != ':') {
+                    if ((value == last_field) || *value != ':') {
                         r->status = HTTP_BAD_REQUEST;
                         apr_table_setn(r->notes, "error-notes",
                             apr_psprintf(r->pool,