From: Tom Lane Date: Mon, 30 Sep 2024 16:06:54 +0000 (-0400) Subject: Remove incorrect entries in pg_walsummary's getopt_long call. X-Git-Tag: REL_18_BETA1~1825 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=04c64e3fb35af090c249303b9df0a311f2a07593;p=thirdparty%2Fpostgresql.git Remove incorrect entries in pg_walsummary's getopt_long call. For some reason this listed "-f" and "-w" as valid switches, though the code doesn't implement any such thing nor do the docs mention them. The effect of this was that if you tried to use one of these switches, you'd get an unhelpful error message. Yusuke Sugie Discussion: https://postgr.es/m/68e72a2a70f4d84c1c7847b13bcdaef8@oss.nttdata.com --- diff --git a/src/bin/pg_walsummary/pg_walsummary.c b/src/bin/pg_walsummary/pg_walsummary.c index 93f6e6d408a..f6a262d3184 100644 --- a/src/bin/pg_walsummary/pg_walsummary.c +++ b/src/bin/pg_walsummary/pg_walsummary.c @@ -71,7 +71,7 @@ main(int argc, char *argv[]) handle_help_version_opts(argc, argv, progname, help); /* process command-line options */ - while ((c = getopt_long(argc, argv, "f:iqw:", + while ((c = getopt_long(argc, argv, "iq", long_options, &optindex)) != -1) { switch (c)