From: Phil Sutter <phil@nwl.cc>
Date: Fri, 11 Jun 2021 16:32:13 +0000 (+0200)
Subject: netlink: Avoid memleak in error path of netlink_delinearize_chain()
X-Git-Tag: v1.0.0~72
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=04f7af9dd66d3a0f627f43bc4bf55bae9856efc8;p=thirdparty%2Fnftables.git

netlink: Avoid memleak in error path of netlink_delinearize_chain()

If parsing udata fails, 'chain' has to be freed before returning to
caller.

Fixes: 702ac2b72c0e8 ("src: add comment support for chains")
Signed-off-by: Phil Sutter <phil@nwl.cc>
---

diff --git a/src/netlink.c b/src/netlink.c
index 41cce337..1bbdf98b 100644
--- a/src/netlink.c
+++ b/src/netlink.c
@@ -599,6 +599,7 @@ struct chain *netlink_delinearize_chain(struct netlink_ctx *ctx,
 		udata = nftnl_chain_get_data(nlc, NFTNL_CHAIN_USERDATA, &ulen);
 		if (nftnl_udata_parse(udata, ulen, chain_parse_udata_cb, ud) < 0) {
 			netlink_io_error(ctx, NULL, "Cannot parse userdata");
+			chain_free(chain);
 			return NULL;
 		}
 		if (ud[NFTNL_UDATA_CHAIN_COMMENT])