From: Andrew Dunstan <andrew@dunslane.net>
Date: Tue, 14 Apr 2020 20:55:34 +0000 (-0400)
Subject: Stop requiring an explicit return from perl subroutines
X-Git-Tag: REL_13_BETA1~242
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=0516f94d18c57cc5dce72ff8fb84a05d24a67063;p=thirdparty%2Fpostgresql.git

Stop requiring an explicit return from perl subroutines

The consensus of the project appears to be that this provides little
benefit and is simply an annoyance.

Discussion: https://postgr.es/m/27481.1586618092@sss.pgh.pa.us
---

diff --git a/src/tools/perlcheck/perlcriticrc b/src/tools/perlcheck/perlcriticrc
index 314c83c6a59..e230111b232 100644
--- a/src/tools/perlcheck/perlcriticrc
+++ b/src/tools/perlcheck/perlcriticrc
@@ -22,7 +22,3 @@ verbose = %f: %m at line %l, column %c.  %e.  ([%p] Severity: %s)\n
 # insist on use of the warnings pragma
 [TestingAndDebugging::RequireUseWarnings]
 severity = 5
-
-# for now raise severity of this to level 5
-[Subroutines::RequireFinalReturn]
-severity = 5